Skip to content

Conversation

@strayMat
Copy link
Contributor

@strayMat strayMat commented Mar 16, 2020

Solve issue #243

  • Change mco sanitize for shared hospital stays :

    • before: MCO.SEJ_TYP != 'B'
    • now: !(MCO.ENT_MOD == 1 and MCO.SOR_MOD == 1)

    Should be equivalent filters in the data but the later is applicable to the whole PMSI and not only to MCO. This change has been made for the three available pmsi : MCO, SSR, HAD.

A Sanitize.md markdown has been added to describe the filters applied to the SNDS when reading the tables. (folder etl/sources).

@strayMat strayMat requested review from vjarry and ysebiat March 16, 2020 09:21
@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #246 into develop will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #246     +/-   ##
==========================================
+ Coverage    93.37%   93.57%   +0.2%     
==========================================
  Files          196      196             
  Lines         2399     2414     +15     
  Branches        51       74     +23     
==========================================
+ Hits          2240     2259     +19     
+ Misses         159      155      -4
Impacted Files Coverage Δ
...hnique/cmap/cnam/etl/sources/data/SsrFilters.scala 100% <100%> (+10%) ⬆️
...chnique/cmap/cnam/etl/sources/data/HadSource.scala 100% <100%> (ø) ⬆️
...hnique/cmap/cnam/etl/sources/data/McoFilters.scala 100% <100%> (ø) ⬆️
...chnique/cmap/cnam/etl/sources/data/SsrSource.scala 100% <100%> (+9.52%) ⬆️
...chnique/cmap/cnam/etl/sources/data/McoSource.scala 100% <100%> (ø) ⬆️
...hnique/cmap/cnam/etl/sources/data/HadFilters.scala 100% <100%> (ø) ⬆️
...map/cnam/etl/sources/data/SsrSourceSanitizer.scala 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b197f52...7d1da1b. Read the comment docs.

- before: MCO.SEJ_TYP != 'B'
- now: !(MCO.ENT_MOD == 1 and MCO.SOR_MOD == 1)

Should be equivalent filters in the data but the later is applicable to the whole PMSI and not only to MCO
@strayMat strayMat force-pushed the DREES-109-Change-mco-sanitize branch from e6fbe5d to 7d1da1b Compare March 16, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants