use atan2 instead of atan to avoid division#13
Open
AJMansfield wants to merge 1 commit intoXRobots:masterfrom
Open
use atan2 instead of atan to avoid division#13AJMansfield wants to merge 1 commit intoXRobots:masterfrom
AJMansfield wants to merge 1 commit intoXRobots:masterfrom
Conversation
no need for that silly 'avoid dividing by zero' rubbish
|
You might want to rebase the PR. Your PR is rewriting the entire file, when in reality only a handful of lines were changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No need for that silly 'avoid dividing by zero' rubbish, just use the two-argument arctangent function.