fixed issue in windows mode changes undoing previous mode changes, fix type on _device com string, add support for binary serial flags in osx/linux#10
Open
czb182 wants to merge 2 commits intoXowap:developfrom
Conversation
reformatting default netbeans 8 style
keep track of all mode parameters for windows, which seems to reset other parameters when not set as part of the mode command added support for setting serial flags in osx/linux for binary communication(not breaking on special characters)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was having issue witih $this->_device = ".com" . $matches[1];
so added another slash after period which fixed the com port string, so that device could be initialized.
I also issues with each successive mode change undoing one of the other calls
For instance, setting data bits to 8, resets parity. In order to do this, I set some windows defaults, then keep track of each change user does so that no change is lost.
I also added call for setting some serial flags in osx/linux for not breaking on special characters. This can be an issue when sending binary data.