Fixed linux DeviceSetup that does not handle any other than ttySXX and made changes how you define port names instead of addresses in DeviceSetup for all platforms.#5
Open
Jeroi wants to merge 6 commits intoXowap:developfrom
Conversation
…M or others. Now it checks weather the device exists in linux and then sets device.
Jeroi
changed the title
Author
|
Now I think for linux part the COMXX naming works for linux ttySXX part and same time accepts other linux names like ttyACM0 without responding unknown device name. |
Jeroi
changed the title
Author
|
I am currently in a process to replace errors with exception handling, stay tuned. |
Owner
|
Cool :) Do you want to merge that in a different PR? I don't really have time for testing just right now, but I'll look into it soon (as well than other PRs) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...r others. Now it checks weather the device exists in linux and then sets device.