🐛 Fix template library install checks#446
Merged
MFA-X-AI merged 4 commits intoXpressAI:masterfrom Oct 9, 2025
Merged
Conversation
MFA-X-AI
requested changes
Oct 2, 2025
Member
MFA-X-AI
left a comment
There was a problem hiding this comment.
Okay so for this, I'd like you to rework it so it doesn't add complexity. I don't like having to add another parameter to pass or introduce a silent state just for this one case. Let's just make it a simple, check if the template required libs are already installed, then if not, prompt the install.
…ified notifications
Contributor
Author
|
I've addressed your feedback and reworked this part as follows:
|
MFA-X-AI
reviewed
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses two issues with template library installation:
Duplicate prompts for already installed libraries
canon()function to normalize library names (e.g.,xai_flask→flask) before comparison.Multiple confirmation dialogs for missing libraries
handleInstall(..., { silent: true })to skip internal confirms and only show one confirmation to the user.Pull Request Type
Type of Change
Tests
1. Already installed libraries
Goal: Ensure templates no longer prompt for libraries that are already installed.
Steps:
xai_flasklibraries.2. Missing library
Goal: Confirm dialog appears only once when one library is missing.
Steps:
Uninstall or remove the
xai_agentandxai_openailibraries.Open Agent Template.
Verify:
AGENTandOPENAI.3. Cancel install
Goal: Verify user cancellation aborts correctly.
Steps:
Uninstall
xai_agent.Open Agent Template.
In the confirm dialog, click Cancel.
Verify:
Tested on? Specify Version.