Skip to content

feat: collapse less common time range sort options under "More" menu#696

Closed
mudkipdev wants to merge 1 commit intoXyphyn:mainfrom
mudkipdev:claude/collapse-sort-options-01UNKv2Q9VLFV2LDP9oqoqYU
Closed

feat: collapse less common time range sort options under "More" menu#696
mudkipdev wants to merge 1 commit intoXyphyn:mainfrom
mudkipdev:claude/collapse-sort-options-01UNKv2Q9VLFV2LDP9oqoqYU

Conversation

@mudkipdev
Copy link
Contributor

  • Reorganized top sort time ranges to show main options first (All time, Past month, Past week, Past day)
  • Added collapsible "More..." section for less common time ranges (9 months, 6 months, 3 months, 12 hours, 6 hours, hour)
  • Updated i18n translations to use more user-friendly labels ("All time", "Past week", "Past month", etc.)
  • "More" section auto-expands when a collapsed option is currently selected

- Reorganized top sort time ranges to show main options first (All time, Past month, Past week, Past day)
- Added collapsible "More..." section for less common time ranges (9 months, 6 months, 3 months, 12 hours, 6 hours, hour)
- Updated i18n translations to use more user-friendly labels ("All time", "Past week", "Past month", etc.)
- "More" section auto-expands when a collapsed option is currently selected
@Xyphyn
Copy link
Owner

Xyphyn commented Dec 2, 2025

  • Should not use hard coded string for More..., and there should not be ellipses
  • Why are we making an entirely new button with tailwind classes? there are components we should be using
  • We should use a submenu not a toggle for more options below
  • Unused imports
  • This ruins accessibility, as it requires a button press in a select menu
  • That button will never appear
  • was this tested?

@Xyphyn Xyphyn closed this Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants