Skip to content

feat: optimized sync_all function and improved UI #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yankyyyy merged 3 commits into from
Sep 17, 2025
+364 −135
Merged

feat: optimized sync_all function and improved UI #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db9bb8f
feat: Github integration with Task and Project doctype
Yankyyyy Sep 16, 2025
403b2b8
feat: optimized sync_all function and improved UI
Yankyyyy Sep 17, 2025
10564b2
bug: datetime error bug fix
Yankyyyy Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 91 additions & 19 deletions ..._github_integration/erpnext_github_integration/doctype/github_settings/github_settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,16 +141,68 @@ frappe.ui.form.on("GitHub Settings", {
// Sync All Repositories button
frm.add_custom_button(__('Sync All Repositories'), function() {
frappe.confirm(__('This will sync all existing repositories. Continue?'), function() {
// Prepare and show a simple progress dialog
const dlg = new frappe.ui.Dialog({
title: __('GitHub Sync Progress'),
fields: [
{ fieldtype: 'HTML', fieldname: 'progress_html' }
],
primary_action_label: __('Close'),
primary_action: function() {
dlg.hide();
}
});

const $progress = $(`
<div style="min-width:420px;padding:10px">
<div class="progress" style="height:20px">
<div class="progress-bar" role="progressbar" style="width:0%">0%</div>
</div>
<div class="mt-2" id="progress_msg"></div>
<div class="mt-2" id="progress_details"></div>
</div>
`);

dlg.fields_dict.progress_html.$wrapper.empty().append($progress);
dlg.show();

// realtime listener (single handler)
frappe.realtime.on('github_sync_progress', (data) => {
try {
const total = data.total || 1;
const progress = data.progress || 0;
const percent = Math.round((progress / total) * 100);
dlg.fields_dict.progress_html.$wrapper.find('.progress-bar').css('width', percent + '%').text(percent + '%');

const msg = data.msg || (data.repo ? (`${data.repo}: ${data.phase || ''}`) : 'Progress update');
$('#progress_msg').text(msg);

// optional details
let details = [];
if (data.repo) details.push(`repo: ${data.repo}`);
if (data.status) details.push(`status: ${data.status}`);
if (data.time_s) details.push(`time: ${data.time_s}s`);
if (typeof data.success !== 'undefined') details.push(`success: ${data.success}`);
if (typeof data.failed !== 'undefined') details.push(`failed: ${data.failed}`);
$('#progress_details').html(details.join(' • '));
} catch (e) {
// ignore UI errors
console.error(e);
}
});

// call the server entrypoint that enqueues the job
frappe.call({
method: 'erpnext_github_integration.github_api.sync_all_repositories',
method: 'erpnext_github_integration.github_api.start_sync_all_repositories',
callback: function(r) {
if (r.message) {
frappe.msgprint({
title: __('Repositories Sync'),
indicator: r.message.failed > 0 ? 'red' : 'green',
message: __(`Success: ${r.message.success}<br>Failed: ${r.message.failed}`)
});
if (r.message && r.message.status === 'queued') {
frappe.msgprint(__('Repository sync queued — watch the progress dialog.'));
} else {
frappe.msgprint(__('Repository sync started.'));
}
},
error: function(err) {
frappe.msgprint(__('Failed to start repo sync: ') + (err && err.message || ''));
}
});
});
Expand Down Expand Up @@ -228,22 +280,42 @@ frappe.ui.form.on("GitHub Settings", {
],
primary_action_label: __('Create Issues'),
primary_action: function(values) {
let issues;
try {
let issues = JSON.parse(values.issues_data);
frappe.call({
method: 'erpnext_github_integration.github_api.bulk_create_issues',
args: {
repository: values.repository,
issues: issues
},
callback: function(r) {
frappe.msgprint(__('Issues created successfully'));
d.hide();
}
});
issues = JSON.parse(values.issues_data);
} catch (e) {
frappe.msgprint(__('Invalid JSON format'));
return;
}

const btn = this.get_primary_btn();
btn.prop('disabled', true).text(__('Creating...'));

frappe.call({
method: 'erpnext_github_integration.github_api.bulk_create_issues',
args: {
repository: values.repository,
issues: issues
},
callback: function(r) {
btn.prop('disabled', false).text(__('Create Issues'));
if (!r || !r.message) {
frappe.msgprint(__('No response from server'));
return;
}
const resp = r.message;
if (resp.created !== undefined) {
frappe.msgprint(__(`Created ${resp.created} issues`));
} else {
frappe.msgprint(__('Issues created successfully'));
}
d.hide();
},
error: function(err) {
btn.prop('disabled', false).text(__('Create Issues'));
frappe.msgprint(__('Error creating issues: ') + (err && err.message || JSON.stringify(err)));
}
});
}
});
d.show();
Expand Down
Loading
Loading