Skip to content

Test #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Yankyyyy wants to merge 3 commits into from
Closed

Test #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5185181
bug: msgprint moved from before frm.save() to after it
Yankyyyy Oct 7, 2025
c07900f
bug:success msg not displayed fix
Yankyyyy Oct 8, 2025
395c53e
bug: blank success message bug fix
Yankyyyy Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 61 additions & 55 deletions erpnext_github_integration/github_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,7 +654,7 @@ def create_issue(repository, title, body=None, assignees=None, labels=None):
frappe.throw(_('GitHub Personal Access Token not configured in GitHub Settings'))

payload = {'title': title}
if body:
if body:
payload['body'] = body
if assignees:
if isinstance(assignees, str):
Expand All @@ -672,36 +672,38 @@ def create_issue(repository, title, body=None, assignees=None, labels=None):
payload['labels'] = labels

resp = github_request('POST', f'/repos/{repository}/issues', token, data=payload)
if resp:
try:
doc = frappe.get_doc({
'doctype': 'Repository Issue',
'repository': repository,
'issue_number': resp.get('number'),
'title': resp.get('title'),
'body': resp.get('body') or '',
'state': resp.get('state'),
'labels': ','.join([l.get('name') if isinstance(l, dict) else str(l) for l in resp.get('labels', [])]),
'url': resp.get('html_url'),
'github_id': str(resp.get('id', '')),
'created_at': convert_github_datetime(resp.get('created_at')),
'updated_at': convert_github_datetime(resp.get('updated_at'))
if not resp:
frappe.throw(_('Failed to create GitHub issue'))

try:
doc = frappe.get_doc({
'doctype': 'Repository Issue',
'repository': repository,
'issue_number': resp.get('number'),
'title': resp.get('title'),
'body': resp.get('body') or '',
'state': resp.get('state'),
'labels': ','.join([l.get('name') if isinstance(l, dict) else str(l) for l in resp.get('labels', [])]),
'url': resp.get('html_url'),
'github_id': str(resp.get('id', '')),
'created_at': convert_github_datetime(resp.get('created_at')),
'updated_at': convert_github_datetime(resp.get('updated_at'))
})
doc.insert(ignore_permissions=True)

for assignee in resp.get('assignees', []):
gh_login = assignee.get('login')
erp_user = frappe.db.get_value("User", {"github_username": gh_login}, "name") or gh_login
doc.append('assignees_table', {
'user': erp_user,
'issue': doc.name
})
doc.insert(ignore_permissions=True)

# Add assignees after insert
for assignee in resp.get('assignees', []):
gh_login = assignee.get('login')
erp_user = frappe.db.get_value("User", {"github_username": gh_login}, "name") or gh_login
doc.append('assignees_table', {
'user': erp_user,
'issue': doc.name
})
doc.save(ignore_permissions=True)
return {'issue': resp, 'local_doc': doc.name}
except Exception:
pass
return resp
doc.save(ignore_permissions=True)
return {'issue': resp, 'local_doc': doc.name}

except Exception as e:
frappe.log_error(frappe.get_traceback(), "GitHub Issue Create Error")
frappe.throw(_('Error while creating local Repository Issue record'))

@frappe.whitelist()
def bulk_create_issues(repository, issues):
Expand Down Expand Up @@ -747,33 +749,37 @@ def create_pull_request(repository, title, head, base, body=None):
frappe.throw(_('GitHub Personal Access Token not configured in GitHub Settings'))

payload = {'title': title, 'head': head, 'base': base}
if body:
if body:
payload['body'] = body

resp = github_request('POST', f'/repos/{repository}/pulls', token, data=payload)
if resp:
try:
doc = frappe.get_doc({
'doctype': 'Repository Pull Request',
'repository': repository,
'pr_number': resp.get('number'),
'title': resp.get('title'),
'body': resp.get('body') or '',
'state': resp.get('state'),
'head_branch': resp.get('head', {}).get('ref'),
'base_branch': resp.get('base', {}).get('ref'),
'author': resp.get('user', {}).get('login'),
'mergeable_state': resp.get('mergeable_state'),
'github_id': str(resp.get('id', '')),
'url': resp.get('html_url'),
'created_at': convert_github_datetime(resp.get('created_at')),
'updated_at': convert_github_datetime(resp.get('updated_at'))
})
doc.insert(ignore_permissions=True)
return {'pull_request': resp, 'local_doc': doc.name}
except Exception:
pass
return resp
if not resp:
frappe.throw(_('Failed to create Pull Request on GitHub'))

try:
doc = frappe.get_doc({
'doctype': 'Repository Pull Request',
'repository': repository,
'pr_number': resp.get('number'),
'title': resp.get('title'),
'body': resp.get('body') or '',
'state': resp.get('state'),
'head_branch': resp.get('head', {}).get('ref'),
'base_branch': resp.get('base', {}).get('ref'),
'author': resp.get('user', {}).get('login'),
'mergeable_state': resp.get('mergeable_state'),
'github_id': str(resp.get('id', '')),
'url': resp.get('html_url'),
'created_at': convert_github_datetime(resp.get('created_at')),
'updated_at': convert_github_datetime(resp.get('updated_at'))
})
doc.insert(ignore_permissions=True)

return {'pull_request': resp, 'local_doc': doc.name}

except Exception as e:
frappe.log_error(frappe.get_traceback(), "GitHub Pull Request Create Error")
frappe.throw(_('Error while creating local Repository Pull Request record'))

@frappe.whitelist()
def sync_repo_members(repo_full_name):
Expand Down
4 changes: 2 additions & 2 deletions erpnext_github_integration/public/js/project_client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ frappe.ui.form.on('Project', {
frm.reload_doc();
}
});
});
}, __('GitHub'));

frm.add_custom_button(__('Sync Repository Data'), function() {
let repo = frm.doc.repository;
Expand All @@ -33,7 +33,7 @@ frappe.ui.form.on('Project', {
frappe.msgprint(__('Error during sync: {0}').format(err.responseText || JSON.stringify(err)));
}
});
});
}, __('GitHub'));
},

after_save: function(frm) {
Expand Down
2 changes: 1 addition & 1 deletion erpnext_github_integration/public/js/task_client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@ frappe.ui.form.on('Task', {
callback: function(r) {
if (r.message) {
let pr = r.message.pull_request;
frappe.msgprint(__('Pull Request Created Successfully'));
frm.set_value('github_pr_number', pr.number);
frm.save();
frappe.msgprint(__('Pull Request Created Successfully'));
}
}
});
Expand Down
Loading