Add a simple particle_system test suite#176
Open
Totobal5 wants to merge 2 commits intoYoYoGames:developfrom
Open
Add a simple particle_system test suite#176Totobal5 wants to merge 2 commits intoYoYoGames:developfrom
Totobal5 wants to merge 2 commits intoYoYoGames:developfrom
Conversation
Contributor
|
You should have created an issue in this repo to propose and document this change in advance, so then any discussions could have been had and we would know what needed to be reviewed - this should always be done before putting up any pull requests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
after issue YoYoGames/GameMaker-Bugs#5728 i made a simple particle_system suit. it include:
I hope this pull and changes are made correctly, if not please tell me to correct it.
Thanks!
Implements the issue #270