Skip to content

Add a simple particle_system test suite#176

Open
Totobal5 wants to merge 2 commits intoYoYoGames:developfrom
Totobal5:test-particles-suit
Open

Add a simple particle_system test suite#176
Totobal5 wants to merge 2 commits intoYoYoGames:developfrom
Totobal5:test-particles-suit

Conversation

@Totobal5
Copy link

@Totobal5 Totobal5 commented Sep 17, 2024

after issue YoYoGames/GameMaker-Bugs#5728 i made a simple particle_system suit. it include:

  1. A test to see if reference names are correct.
  2. A test to see if part_system_create variants correctly create a part_system.
  3. A test to see if particle systems made with a persistent option are keep in another room (it check if a part system made without a persisten tag are keeping in memory too)
  4. And various test with part_system_get_info to see if the information returned are in line with what the documentation tells what it should return.

I hope this pull and changes are made correctly, if not please tell me to correct it.
Thanks!

Implements the issue #270

@YYDan
Copy link
Contributor

YYDan commented Feb 17, 2025

You should have created an issue in this repo to propose and document this change in advance, so then any discussions could have been had and we would know what needed to be reviewed - this should always be done before putting up any pull requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments