Added BasicCompileEvalConsistencyTestSuite#269
Open
tinkerer-red wants to merge 1 commit intoYoYoGames:developfrom
Open
Added BasicCompileEvalConsistencyTestSuite#269tinkerer-red wants to merge 1 commit intoYoYoGames:developfrom
tinkerer-red wants to merge 1 commit intoYoYoGames:developfrom
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test suite is intended to ensure consistency between compile time optimizations and results. Currently it is strictly focused on the basic math functions and the varying input types. Possibly future testsuites could include the string compile times, and the dot product results. But that's out of scope for this test suite. This code was generated from the following python script. So if there are any global over arching issues with the test suite they can be easily changed.
https://gist.github.com/tinkerer-red/c7416fc7c2affd875aa313d9d3e71ffc
This aims to assist in resolving several of the issues which were introduced by the compile time optimizations:
YoYoGames/GameMaker-Bugs#10043
YoYoGames/GameMaker-Bugs#10029
YoYoGames/GameMaker-Bugs#8022
YoYoGames/GameMaker-Bugs#8021
As a note most of these are already resolving correctly apart from bitwise ops compiling literals as numbers, and a few bitshift errors, but these may already be resolves from Russell's recent work on 10029 which fixes
0xand0bto keep respect to int64.