Fix issues related to running the RN example app on iOS#5
Open
palexs wants to merge 2 commits intoYodlee:mainfrom
Open
Fix issues related to running the RN example app on iOS#5palexs wants to merge 2 commits intoYodlee:mainfrom
palexs wants to merge 2 commits intoYodlee:mainfrom
Conversation
palexs
commented
Jul 15, 2024
| # | ||
| # Note that if you have use_frameworks! enabled, Flipper will not work and | ||
| # you should disable these next few lines. | ||
| add_flipper_pods! |
Author
There was a problem hiding this comment.
Flipper causes a lot of issues, so I decided to de-integrate it to get the example app running.
palexs
commented
Jul 15, 2024
| "version": "0.0.1", | ||
| "private": true, | ||
| "engines": { | ||
| "node": "16.x" |
Author
There was a problem hiding this comment.
Fixes this error spat out by Metro bundler:
palexs
commented
Jul 15, 2024
| "eslint": "^6.5.1", | ||
| "jest": "^24.9.0", | ||
| "metro-react-native-babel-preset": "^0.58.0", | ||
| "metro-react-native-babel-preset": "^0.59.0", |
palexs
commented
Jul 15, 2024
| generationCount); | ||
| node->setLayoutHadOverflow( | ||
| - node->getLayout().hadOverflow() | | ||
| + node->getLayout().hadOverflow() || |
palexs
commented
Jul 15, 2024
| "permitted. You must either @synthesize the bridge property, " | ||
| "or provide your own setter method.", | ||
| - RCTBridgeModuleNameForClass(strongModule)); | ||
| + RCTBridgeModuleNameForClass(Class(strongModule))); |
palexs
commented
Jul 15, 2024
| } | ||
|
|
||
| -- (NSArray<RCTModuleData *> *)_initializeModules:(NSArray<id<RCTBridgeModule>> *)modules | ||
| +- (NSArray<RCTModuleData *> *)_initializeModules:(NSArray<Class> *)modules |
palexs
commented
Jul 15, 2024
| platform :ios, '11.0' | ||
| require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules' | ||
|
|
||
| def add_flipper_pods!(versions = {}) |
Author
There was a problem hiding this comment.
Most of the Flipper integration code could be substituted by the usage of the use_flipper script, but this requires upgrading react-native (https://fbflipper.com/docs/getting-started/react-native-ios/#react-native-063).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I attempted to run the
react-nativeexample app I faced multiple issues. Most of them stem from the fact that the repo hasn't been updated for a while and unfortunately the codebase looks like it's not actively maintained anymore. In this PR I tried to fix the build and runtime errors I stumbled upon.Please, keep in mind that these fixes are just a stopgap and the example app should be properly updated to support the newer version of
react-nativeframework and the corresponding build tools (Xcode, Cocoapods, Node, etc).