Python-pyhsm conversion to work with python3 #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to make python-pyhsm work with python3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a python-pyhsm package conversion to make it work with python3.
Bumped up dependencies to python3 as well, changed crypto library to pycryptodome, converted the code to python3 standarts, changed the data moving to hsm device from string and other formats to bytes.
Launching tests they do pass successfully (thought sometimes the OTP testing returns OTP_INVALID error, no clue if its a timing thing or something else, but after 2-3 tries it does pass, testing on a installed package OTP works correctly).
Only problems I have is that I have no way to test files in /ksm directory, /val/init_oath_token.py and /tools directory files besides keystore_unlock.py, as I don't have any spare yubikeys to configure a new hsm with (but I don't see why they wouldnt be working, as changes are minimal).
Variable types in methods description are still not changed from string to bytes and some of the code is still a bit messy, but if it's possible to push this change upstream I'll make the changes later.