-
Notifications
You must be signed in to change notification settings - Fork 1
GA-114 android client #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GA-122 set up the project
…king GA-123 retrofit networking
GA-124 Model classes for retrofit
GA-125 jwt tokens
…ern-and-ViewModel GA-126 repository pattern and view model
GA-127 authentication activity
GA-128 inbox screen
GA-139 android labels
fixed bug where profile image wouldn't load on auto login
…or saving/sending
GA-130 Compose mail
GA-133 Room
android bug fixes
GA-140 Finalizing app
RoeeHaim
approved these changes
Aug 31, 2025
Collaborator
RoeeHaim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing work!
dor-darmon
approved these changes
Aug 31, 2025
Collaborator
dor-darmon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished the android app. I tried to stay as close as possible to the real gmail app.
Included:
a. skipped formatting of text when writing mails - like the real gmail
b. skipped editing and deleting labels - like the real gmail
c. skipped saving sender's image when caching since base64 takes a lot of space and might break the app if there are too many users