GA-136 finalize sprint #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuvalAnteby
requested review from
RoeeHaim and
dor-darmon
and removed request for
dor-darmon
dor-darmon
reviewed
Jul 25, 2025
Collaborator
There was a problem hiding this comment.
REACT_APP_NAME='Mail ASP' Check that the variable is not captured with ' '
dor-darmon
approved these changes
Jul 25, 2025
Collaborator
|
Attachment (33).pdf |
RoeeHaim
approved these changes
Jul 25, 2025
Owner
Author
יש לציין שזה עוד 5 ימים בנוסף לימים הקודמים במהלך הסמסטר |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added env files (easier setup for the checkers)
Added screenshots
Updated READMEs for root, Node.js and React services
Ready for check guys