Conversation
- Add variable used when filling SSH & OSH with non repeatable items (NRI) - Add check to stop warning about too many items and not enough locations for SSH & OSH NRI - Add check to stop placement from attempting to continue after all locations were filled in SSH & OSH NRI situation - Changes SSH & OSH NRI Fill from FastFill to AssumedFill to prevent softlocks and item placement issues
fixed spaces to appease phlex
Adjust all AssumedFIll calls to have locationshintable be true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Ensure FD mask check is done properly in correct scene
fix: Adjust warnings in LD file during build
fix: Item placement will no longer duplicate items with Plentiful setting turned off
fix: Use
AssumedFillinstead ofFastFillon items when no repeating items is selected, which should also fix the generation bug that would fail placement.