feat: logo image in pixel-perfect scaling#1
Open
denilsonsa wants to merge 1 commit intoZQuestClassic:mainfrom
Open
feat: logo image in pixel-perfect scaling#1denilsonsa wants to merge 1 commit intoZQuestClassic:mainfrom
denilsonsa wants to merge 1 commit intoZQuestClassic:mainfrom
Conversation
The old `ZC_Logo.png` was upscaled with a non-integer multiplier. This means the original pixels were scaled to regions of either 9x9, 9x10, 10x9 or 10x10 pixels. This commit removes that PNG image and instead puts a "raw" 1x-zoom PNG image (i.e. no scaling, each pixel is one pixel). For convenience, it also adds a bigger 8x-zoom image. I don't know why we had that older image, so I'm just guessing that 8x is large enough for the purposes it previously had. See also: ZQuestClassic/ZQuestClassic#1004 Next steps: tackle those icon images. They have a different set of issues.
denilsonsa
added a commit
to denilsonsa/ZQuestClassic
that referenced
this pull request
Oct 27, 2024
The `align` attribute has been deprecated for ages, and shouldn't be used anymore. The `width` and `height` attributes are only valid in a few tags (such as `img`) and they should be plain integers corresponding to the CSS pixel dimensions. The dimensions listed here are based on the adjusted image I proposed in ZQuestClassic#1004 and ZQuestClassic/commons#1 . Of course we can fine-tune those dimensions if the image changes. * https://html.spec.whatwg.org/#dimension-attributes * https://www.w3.org/TR/html5-diff/#obsolete-attributes * https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes
Author
|
Talking about the icons, while the background shield aligns nicely to a 3x3 grid (i.e. it was perfectly scaled to 3x), the ZC letters were scaled to 4.5x, which means each exploded pixel would be either 4x4 or 5x5 square, or 4x5 or 5x4 rectangle. Ugh. So I cleaned up the ZC letters, zoomed them up to 3x (to match the shield) and tried a few variations. Which one do you like best?
And, for comparison, here's the
I can later send a PR with the chosen variant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old
ZC_Logo.pngwas upscaled with a non-integer multiplier. This means the original pixels were scaled to regions of either 9x9, 9x10, 10x9 or 10x10 pixels.This commit removes that PNG image and instead puts a "raw" 1x-zoom PNG image (i.e. no scaling, each pixel is one pixel).
For convenience, it also adds a bigger 8x-zoom image. I don't know why we had that older image, so I'm just guessing that 8x is large enough for the purposes it previously had.
See also: ZQuestClassic/ZQuestClassic#1004
Next steps: tackle those icon images. They have a different set of issues.