fix: prevent stale WebSocket handlers from corrupting reconnection state#38
Merged
wizzomafizzo merged 1 commit intomainfrom Feb 7, 2026
Merged
Conversation
Three bugs caused the app to get stuck in permanent "reconnecting" state after resuming from background: 1. createWebSocket() replaced this.ws without cleaning up old handlers. Stale onclose callbacks would fire on the transport, scheduling duplicate reconnection timers and leaking WebSocket instances. 2. pauseHeartbeat() didn't clear reconnectTimer, allowing background reconnection loops when the WebSocket died while the app was backgrounded. 3. Pong timeout called ws.close() then handleDisconnection(), but the subsequent onclose event triggered handleDisconnection() again, creating parallel reconnection paths. Extract closeWebSocket() helper to null handlers before closing, reused in createWebSocket(), cleanup(), and pong timeout.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createWebSocket()now closes old WebSocket (nulling handlers) before creating a new one, preventing staleonclosecallbacks from scheduling duplicate reconnection timerspauseHeartbeat()now clearsreconnectTimer, preventing background reconnection loops when the WebSocket dies while backgroundedscheduleReconnect()is blocked whenheartbeatPausedis true, sooncloseevents during pause can't start new reconnection cyclescloseWebSocket()to null handlers before close, preventingonclosefrom triggering a duplicatehandleDisconnection()closeWebSocket()helper reused increateWebSocket(),cleanup(), and pong timeout