fix(platform): dispatch BigBox PlayGame calls to WPF UI thread#527
Open
wizzomafizzo wants to merge 3 commits intomainfrom
Open
fix(platform): dispatch BigBox PlayGame calls to WPF UI thread#527wizzomafizzo wants to merge 3 commits intomainfrom
wizzomafizzo wants to merge 3 commits intomainfrom
Conversation
LaunchGameById is called from a background thread (named pipe reader), but BigBoxMainViewModel.PlayGame requires the WPF UI thread. Capture the Dispatcher during plugin init and use Invoke() to marshal PlayGame calls onto it. Closes #509
ShowGame navigates BigBox UI to the NFC-scanned game, firing LEDBlinky Event 9 (game selection). Without this, LEDBlinky shows controls for whichever game the user had highlighted in the BigBox menu rather than the game actually being launched.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlayGamecalls to the WPF UI thread viaDispatcher.Invoke()— the named pipe reader runs on a background thread which causes BigBox to silently failDispatcherduring plugin initialization (PluginInitialized,LaunchBoxStartupCompleted,BigBoxStartupCompleted) for reliable access from background threadsNullReferenceExceptionShowGame()beforePlayGame()in BigBox mode so LEDBlinky receives Event 9 (game selection) for the NFC-scanned game — without this, LEDBlinky shows controls for whichever game was highlighted in the BigBox menuCloses #509