fix(mister): embed ArcadeDB CSV as fallback for offline first boot#530
Merged
wizzomafizzo merged 2 commits intomainfrom Feb 8, 2026
Merged
fix(mister): embed ArcadeDB CSV as fallback for offline first boot#530wizzomafizzo merged 2 commits intomainfrom
wizzomafizzo merged 2 commits intomainfrom
Conversation
When MiSTer/MiSTeX has no internet on first boot, the ArcadeDB CSV cannot be downloaded, causing arcade game lookups to fail silently. Bundle the CSV into production builds via go:embed with a build tag so the runtime download still takes priority but offline users get a functional baseline. Closes #526
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
gocsv silently accepts malformed CSV rows, producing entries with empty Setname or Name fields. These create useless mappings in the tracker's name map. Filter them out in both the disk and embedded read paths, and return an error from readEmbedded if no usable entries remain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
//go:embedwith theembed_arcadedbbuild tag, so arcade game lookups work on first boot without internetRead()falls back to the embedded data when the on-disk CSV is missing; the runtime download still takes prioritydownload-arcadedbTaskfile task that MiSTer/MiSTeX builds depend on, and plumbsEXTRA_TAGSthrough the build chain (Taskfile, zigcc, docker)Closes #526