fix(mediascanner): add diagnostic logging and tests for custom launcher file matching#531
Merged
wizzomafizzo merged 1 commit intomainfrom Feb 8, 2026
Merged
Conversation
…er file matching (#517, #507) Custom launchers with media_dirs configured are not having their files indexed into the media database on Windows. Code-level tests confirm the matching logic is correct, so this adds diagnostic logging throughout the custom launcher pipeline to reveal why files don't match on affected machines.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Investigates #517 and #507 — custom launchers with
media_dirsconfigured are not having their files indexed into the media database on Windows.PathIsLauncherandMatchSystemFilewith custom launchers using absolute folder paths, emptyRootDirs, mixed built-in/custom launchers, and edge cases — all pass, confirming the matching logic is correct and the bug is environmentalLoadCustomLaunchersto reveal deserialization issues (wrong keys, empty values)ParseCustomLauncherslogging from debug to info with full folder paths and extensions instead of just countsLauncherCache.Initializeto verify cache populationGetFileswhen a directory walk finds entries but 0 files match any launcherMatchSystemFilewhen no launcher matches a file, showing how many launchers were checkedRefs #517, refs #507