ZIP-558: modifies spec for taxabilityCode param#4
Merged
ericlakich merged 2 commits intomainfrom Jan 22, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR corrects the OpenAPI specification for the taxabilityCode query parameter by changing it from a date format to a single-digit number format.
Changes:
- Updated
taxabilityCodeparameter format from "date" to "number" - Modified validation pattern to accept single-digit numbers instead of YYYY-MM date format
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the OpenAPI specification in
docs/spec.yamlto correct the format and validation pattern for thetaxabilityCodequery parameter. The change ensures the parameter is defined as a number rather than a date, and updates its validation accordingly.Specification corrections:
taxabilityCodeparameter's format from"date"to"number"to reflect its intended usage.taxabilityCodefrom a date format ("^[0-9]{4}-[0-9]{2}$") to a single digit number ("^[0-9]$").