Chore: update versions #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Regarding your note
This is an open issue in the flutter_isolate package rmawatson/flutter_isolate#108 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ankidroid does not support using implementation 'com.github.ankidroid:Anki-Android:api-v1.1.0' anymore, resolving this fails. See this issue ankidroid/Anki-Android#15052
Therefore, this PR updates the ankidroid package to v2.17.4 and updates the Kotlin code to match this new version. Now this plugin also compiles mixed with other code that targets kotlin 1.9.
Additionally, I removed the
askForPermissioncall from createAnkiIsolate. Asking immediately for permission makes it basically impossible to start one isolate at the start of the app and communicate with it when necessary because the user is asked to grant access to anki without an obvious reason. Therefore documentation to indicate that has also been added.Let me know if there are any issues with this PR.