Skip to content

[ECO-5606] fix: enforce Locale.ROOT for string formatting in StreamsChannel #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ttypic merged 1 commit into from
Oct 27, 2025
Merged

[ECO-5606] fix: enforce Locale.ROOT for string formatting in StreamsChannel #581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions .github/workflows/flutter_integration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,6 @@ on:

jobs:
ios:
strategy:
matrix:
device: # Device names must be shown in `xcrun simctl list devices`
- 'iPhone 15' # we are not specifying the iOS version as it tends to change
fail-fast: false
runs-on: macos-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -22,7 +17,7 @@ jobs:

- uses: subosito/flutter-action@v2
with:
flutter-version: '3.24'
flutter-version: '3.29'
cache: true

# test_integration package depends on ably_flutter, so before we run integration
Expand Down
8 changes: 3 additions & 5 deletions android/src/main/java/io/ably/flutter/plugin/StreamsChannel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,10 @@

package io.ably.flutter.plugin;

import android.annotation.SuppressLint;

import androidx.annotation.UiThread;

import java.nio.ByteBuffer;
import java.util.Locale;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.atomic.AtomicBoolean;

Expand Down Expand Up @@ -160,7 +159,7 @@ void clearAll() {
}

private void logError(long id, String message, Throwable e) {
Log.e(TAG + name, String.format("%s [id=%d]", message, id), e);
Log.e(TAG + name, String.format(Locale.ROOT, "%s [id=%d]", message, id), e);
}

private final class EventSinkImplementation implements EventChannel.EventSink {
Expand All @@ -169,10 +168,9 @@ private final class EventSinkImplementation implements EventChannel.EventSink {
final String name;
final AtomicBoolean hasEnded = new AtomicBoolean(false);

@SuppressLint("DefaultLocale")
private EventSinkImplementation(long id) {
this.id = id;
this.name = String.format("%s#%d", StreamsChannel.this.name, id);
this.name = String.format(Locale.ROOT, "%s#%d", StreamsChannel.this.name, id);
}

@Override
Expand Down
Loading