Skip to content

Release/1.2.41#582

Merged
ttypic merged 2 commits intomainfrom
release/1.2.41
Oct 28, 2025
Merged

Release/1.2.41#582
ttypic merged 2 commits intomainfrom
release/1.2.41

Conversation

@ttypic
Copy link
Contributor

@ttypic ttypic commented Oct 28, 2025

  • Fixed the issue when the device locale has its own digits symbols #581
  • Fixed warnings in build scripts for new flutter versions #579

Summary by CodeRabbit

  • Bug Fixes

    • Fixed locale digits symbols display issue on devices with specific locale settings
    • Resolved build script warnings for improved compatibility with newer Flutter versions
  • Documentation

    • Updated installation guides and code examples to reflect version 1.2.41

@ttypic ttypic requested a review from sacOO7 October 28, 2025 06:17
@coderabbitai
Copy link

coderabbitai bot commented Oct 28, 2025

Walkthrough

This PR updates the package version to 1.2.41, adding changelog entries for locale digits and build script warnings fixes. Documentation dependencies are updated, and Toast.framework references are removed from iOS build configuration.

Changes

Cohort / File(s) Change Summary
Version & Changelog Updates
pubspec.yaml, CHANGELOG.md
Version bumped from 1.2.40 to 1.2.41; changelog entry added with two bug fixes: locale digits symbols issue and build script warnings for new Flutter versions
Documentation
README.md
Updated ably_flutter dependency version references from ^1.2.40 to ^1.2.41 in two code snippets (pubspec.yaml example and installation section)
iOS Build Configuration
example/ios/Runner.xcodeproj/project.pbxproj
Removed Toast.framework references from Pods embed script inputs and corresponding output paths

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • The iOS build config change (Toast.framework removal) warrants verification to ensure no unintended side effects on the build process

Poem

🐰 A hop, a skip, one-point-two-four-one,
Locale digits fixed, the warnings are gone!
Toast frames removed from the iOS compile,
Documentation bumped—a version-bump smile! 🎉

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "Release/1.2.41" directly describes the main purpose of the changeset, which is to prepare and release version 1.2.41 of the package. The title is specific (indicating the exact version number), concise, and follows a clear convention that developers would immediately recognize as a release PR. A teammate scanning the repository history would understand that this PR is responsible for the 1.2.41 release without ambiguity. While the title doesn't enumerate the specific fixes included (locale handling and build script warnings), the guidelines acknowledge that comprehensive coverage of all details is not required; identifying the primary change—the version bump and release—is sufficient.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch release/1.2.41

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 46d07f0 and ef2972f.

⛔ Files ignored due to path filters (4)
  • example/ios/Podfile.lock is excluded by !**/*.lock
  • example/pubspec.lock is excluded by !**/*.lock
  • test_integration/ios/Podfile.lock is excluded by !**/*.lock
  • test_integration/pubspec.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • CHANGELOG.md (1 hunks)
  • README.md (1 hunks)
  • example/ios/Runner.xcodeproj/project.pbxproj (0 hunks)
  • pubspec.yaml (1 hunks)
💤 Files with no reviewable changes (1)
  • example/ios/Runner.xcodeproj/project.pbxproj
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: android
  • GitHub Check: ios
  • GitHub Check: android (29)
  • GitHub Check: android (24)
  • GitHub Check: ios
🔇 Additional comments (3)
pubspec.yaml (1)

3-3: Version bump looks good.

Patch version increment from 1.2.40 to 1.2.41 is appropriate for bug fixes. Environment and dependency constraints remain unchanged, maintaining compatibility guarantees.

README.md (1)

57-57: Documentation version update is consistent.

Version reference updated to match pubspec.yaml. The caret constraint (^1.2.41) is idiomatic and allows users to receive compatible patch updates.

CHANGELOG.md (1)

3-8: Changelog entry is well-structured and consistent.

Version 1.2.41 entry follows the established format with accurate PR references (#581 for locale digits fix, #579 for build script warnings). The comparison link and markdown formatting are correct.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Collaborator

@sacOO7 sacOO7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ttypic ttypic merged commit aca05b9 into main Oct 28, 2025
11 of 12 checks passed
@ttypic ttypic deleted the release/1.2.41 branch October 28, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants