-
Notifications
You must be signed in to change notification settings - Fork 46
Fix jetpack snippets for android #3190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
853cb94
Renamed android specific kotlin/jetpack snippets to android
sacOO7 d3a3c97
Created jetpack to android annotation migration plan using opus 4.6
sacOO7 d0b095f
Updated plan to migrate to chat_android, covered all edge cases
sacOO7 046a370
Implemented jetpack to chat android lang. snippet migration according…
sacOO7 a2e967d
Fixed build issue where codeblock is not able to resolve the proper l…
sacOO7 01a1c14
Fixed android icon for the chat android snippet
sacOO7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -26,7 +26,7 @@ export const languageKeys = [ | |||
| 'css', | ||||
| 'laravel', | ||||
| 'typescript', | ||||
|
||||
| 'typescript', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chat_androidcode fences are now being used in Chat MDX pages, butlanguageData.chatis keyed onandroid. This only works if the runtime language normalization (viastripSdkTypefrom@ably/ui) strips thechat_prefix and the CodeSnippet component can map the activeandroidselection back tochat_androidblocks. If@ably/uiin this repo doesn’t yet supportchat_prefixes, Android snippets/conditionals will fail to render. Please ensure the required@ably/uichanges/version bump lands alongside this PR (or adjust the docs to use the currently supported language key).