Conversation
Filter GMMA directories out of the default microbenchmark build and add dedicated `gmma` / `GPU_Microbenchmark_gmma` targets so GMMA benchmarks can be compiled independently without affecting the standard build. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
JRPan
commented
Feb 7, 2026
Contributor
Author
JRPan
left a comment
There was a problem hiding this comment.
Review
Changes look good. Here's a summary of what this PR does:
src/cuda/GPU_Microbenchmark/Makefile
- Renames
SUB_DIRStoALL_SUB_DIRSto hold all subdirectories, then splits them:GMMA_DIRS— directories ending ingmma/(via$(filter %gmma/))SUB_DIRS— everything else (via$(filter-out))
- Adds
gmmaandclean_gmmatargets that mirror the existingall/cleantargets but operate only on GMMA directories.
src/Makefile
- Adds a top-level
GPU_Microbenchmark_gmmatarget that invokes the newgmmasub-target and moves the resulting binaries into the output directory.
Notes
- The
%gmma/filter pattern will match any subdirectory whose name ends withgmma. If a non-GMMA benchmark name ever ends ingmmait would be incorrectly filtered — unlikely but worth keeping in mind. - The existing
allandcleantargets are unaffected for non-GMMA benchmarks; this is a purely additive change.
LGTM ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gmma/GPU_Microbenchmark_gmmaMake targets to compile GMMA benchmarks independentlyclean_gmmatarget for cleanupTest plan
make GPU_Microbenchmarkand verify GMMA directories are excludedmake GPU_Microbenchmark_gmmaand verify only GMMA benchmarks are builtmake cleanin GPU_Microbenchmark still works for non-GMMA targets🤖 Generated with Claude Code