[Feature 693] Change theme selection control#708
Open
denete wants to merge 3 commits intoaccius:Stagingfrom
Open
[Feature 693] Change theme selection control#708denete wants to merge 3 commits intoaccius:Stagingfrom
denete wants to merge 3 commits intoaccius:Stagingfrom
Conversation
added a preview panel to let users see theme as selected, changed to hex only to avoid bug with rgba selector and custom theme storage, included theme attribute removal in application of custom theme
incorrectly with a string instead of an object, moved excessive styles from style preview to main.css, added reset for custom theme, added translations for theme reset, removed unused functions from the button theme selectors
passed by props from a parent, added translations for sample button text
3 tasks
Contributor
Author
|
This addresses #693. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The current button approach does not lend itself to offering more than a small handful of themes. With the idea of allowing more user-contributed themes, moving to a more compact interface would be preferred. This PR does the following.
Type of change
How to test
Checklist
server.js: caches have TTLs and size caps (we serve 2,000+ concurrent users)var(--accent-cyan), etc.).bak,.old,console.logdebug lines, or test scripts includedScreenshots (if visual change)
Before...
After...