fix: add type checking for optional properties #53
+67
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add compile-time type checking for optional properties in TemplateMark templates. When an optional property is used without a guard (
{{#optional}},{{#if}}, or{{#with}}), the type-checker now throws an error at compile time instead of causing a runtime failure.Before: Runtime error -
"No values found for path '$['last']'"After: Compile-time error -
"Optional properties used without guards: last"Changes
.errorsproperty for structured accesstest/templates/bad/optional-noguard/Testing
All 26 TemplateMarkInterpreter tests pass. All 33 snapshots pass.
Related Issues
Fixes accordproject/template-playground#11