Add tsconfig files to .npmignore entries for TypeScript SDK#559
Add tsconfig files to .npmignore entries for TypeScript SDK#559devksingh4 merged 2 commits intomainfrom
Conversation
💰 Infracost reportMonthly estimate generatedThis comment will be updated when code changes. |
WalkthroughThe pull request contains a version bump in package.json from 4.1.10 to 4.1.11 and modifies the .npmignore configuration in src/api/generateClients.ts to add two TypeScript configuration files (tsconfig.json and tsconfig.esm.json) to the list of files excluded from npm package distribution, alongside the existing docs/ and src/ entries. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/api/generateClients.ts`:
- Line 79: The inline comment "Add docs/ to .npmignore" is stale; update it to
describe all current entries in the array (replace the single-item text with a
short phrase like "Add docs/, <entry2>, <entry3>, <entry4> to .npmignore" or
"Add additional paths to .npmignore (docs/, ..., ...)" so it accurately reflects
the array's contents); locate the comment by searching for the exact string "Add
docs/ to .npmignore" in generateClients.ts and edit the comment near the
npmignore array to list or summarize the four entries currently present.
| @@ -78,7 +78,7 @@ function patchPackageJson(): void { | |||
|
|
|||
| // Add docs/ to .npmignore | |||
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Stale comment should be updated.
The comment only mentions "docs/" but the array now includes four entries. Consider updating it to reflect the actual purpose.
📝 Suggested comment update
- // Add docs/ to .npmignore
+ // Add entries to .npmignore to reduce package size📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| // Add docs/ to .npmignore | |
| // Add entries to .npmignore to reduce package size |
🤖 Prompt for AI Agents
In `@src/api/generateClients.ts` at line 79, The inline comment "Add docs/ to
.npmignore" is stale; update it to describe all current entries in the array
(replace the single-item text with a short phrase like "Add docs/, <entry2>,
<entry3>, <entry4> to .npmignore" or "Add additional paths to .npmignore (docs/,
..., ...)" so it accurately reflects the array's contents); locate the comment
by searching for the exact string "Add docs/ to .npmignore" in
generateClients.ts and edit the comment near the npmignore array to list or
summarize the four entries currently present.
Summary by CodeRabbit