Skip to content

Add tsconfig files to .npmignore entries for TypeScript SDK#559

Merged
devksingh4 merged 2 commits intomainfrom
devksingh4-patch-2
Feb 5, 2026
Merged

Add tsconfig files to .npmignore entries for TypeScript SDK#559
devksingh4 merged 2 commits intomainfrom
devksingh4-patch-2

Conversation

@devksingh4
Copy link
Member

@devksingh4 devksingh4 commented Feb 5, 2026

Summary by CodeRabbit

  • Chores
    • Patch version released (4.1.11).
    • Updated npm package publication configuration to exclude additional configuration files.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

💰 Infracost report

Monthly estimate generated

This comment will be updated when code changes.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026

Walkthrough

The pull request contains a version bump in package.json from 4.1.10 to 4.1.11 and modifies the .npmignore configuration in src/api/generateClients.ts to add two TypeScript configuration files (tsconfig.json and tsconfig.esm.json) to the list of files excluded from npm package distribution, alongside the existing docs/ and src/ entries.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding tsconfig files to .npmignore entries, which is confirmed by the modifications in generateClients.ts.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch devksingh4-patch-2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@src/api/generateClients.ts`:
- Line 79: The inline comment "Add docs/ to .npmignore" is stale; update it to
describe all current entries in the array (replace the single-item text with a
short phrase like "Add docs/, <entry2>, <entry3>, <entry4> to .npmignore" or
"Add additional paths to .npmignore (docs/, ..., ...)" so it accurately reflects
the array's contents); locate the comment by searching for the exact string "Add
docs/ to .npmignore" in generateClients.ts and edit the comment near the
npmignore array to list or summarize the four entries currently present.

@@ -78,7 +78,7 @@ function patchPackageJson(): void {

// Add docs/ to .npmignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Stale comment should be updated.

The comment only mentions "docs/" but the array now includes four entries. Consider updating it to reflect the actual purpose.

📝 Suggested comment update
-  // Add docs/ to .npmignore
+  // Add entries to .npmignore to reduce package size
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
// Add docs/ to .npmignore
// Add entries to .npmignore to reduce package size
🤖 Prompt for AI Agents
In `@src/api/generateClients.ts` at line 79, The inline comment "Add docs/ to
.npmignore" is stale; update it to describe all current entries in the array
(replace the single-item text with a short phrase like "Add docs/, <entry2>,
<entry3>, <entry4> to .npmignore" or "Add additional paths to .npmignore (docs/,
..., ...)" so it accurately reflects the array's contents); locate the comment
by searching for the exact string "Add docs/ to .npmignore" in
generateClients.ts and edit the comment near the npmignore array to list or
summarize the four entries currently present.

@devksingh4 devksingh4 merged commit 2e32481 into main Feb 5, 2026
13 of 14 checks passed
@devksingh4 devksingh4 deleted the devksingh4-patch-2 branch February 5, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant