feat(diff): add filler virtual lines for PR review pane alignment#112
Merged
actionshrimp merged 1 commit intomainfrom Feb 23, 2026
Merged
feat(diff): add filler virtual lines for PR review pane alignment#112actionshrimp merged 1 commit intomainfrom
actionshrimp merged 1 commit intomainfrom
Conversation
When review threads are rendered as virt_lines on one side of the side-by-side diff viewer, the opposite buffer drifts out of sync. Track virt_line counts per side per buffer line and add matching filler lines (GitladReviewFiller) on the side with fewer to maintain visual alignment. Works for both review threads and pending comments.
actionshrimp
commented
Feb 23, 2026
| GitladReviewResolved = { link = "Comment" }, | ||
| GitladReviewOutdated = { link = "DiagnosticWarn" }, | ||
| GitladReviewPending = { link = "DiagnosticHint" }, | ||
| GitladReviewFiller = { link = "GitladDiffFiller" }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
virt_lineson one side of the side-by-side diff viewer, the opposite buffer drifts out of visual syncvirt_lines(using newGitladReviewFillerhighlight group) on the side with fewer lines to keep panes alignedTest plan
make test-file FILE=tests/unit/test_diff_review.lua— 37 tests pass (7 new)make test— all 1536 unit + 622 e2e tests passmake lint— clean