feat(checks): collapsible sub-sections for CI checks by category#116
Merged
actionshrimp merged 1 commit intomainfrom Feb 24, 2026
Merged
feat(checks): collapsible sub-sections for CI checks by category#116actionshrimp merged 1 commit intomainfrom
actionshrimp merged 1 commit intomainfrom
Conversation
When a status category (failed, in_progress, successful, pending, skipped) has more than 5 checks, group them into a collapsible sub-section with an indented header. Categories with ≤5 checks render flat as before. Tab on a sub-section header toggles just that category; gj/gk navigate to sub-section headers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<Tab>on a sub-section header toggles just that category;<Tab>on the main Checks header still toggles the entire sectiongj/gknavigate to sub-section headers as well as individual checksFiles changed
lua/gitlad/ui/components/checks.lua—classify_check(), category-based bucketing, sub-section rendering + highlightslua/gitlad/ui/views/pr_detail.lua—checks_sub_collapsedstate, toggle logic, nav targetslua/gitlad/ui/components/comment.lua— passthrough of sub-collapsed state + highlight delegationtests/unit/test_checks_component.lua— 14 new tests (classify, sub-section threshold, collapse, ordering, ranges)tests/e2e/test_pr_detail.lua— 3 new tests (sub-section header appears, Tab toggles, gj/gk navigates)tests/fixtures/github/pr_detail_many_checks.json— fixture with 9 checks (7 successful, 2 failed)Test plan
make test-file FILE=tests/unit/test_checks_component.lua— 29 tests passmake test-file FILE=tests/e2e/test_pr_detail.lua— 22 tests passmake test— full suite green (1555 unit + 631 e2e)make lint— clean