Skip to content

Conversation

@josevsalina
Copy link
Contributor

@josevsalina josevsalina commented Oct 5, 2023

Description of the change

  • Returning an error message with a description for invalid json
  • Fixing an issue with html library
  • upgrading to node 20

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change
  • Technical Debt
  • Documentation

Related tickets

Link to Shortcut/Jira Ticket Goes Here

Checklists

Development and Testing

  • Lint rules pass locally.
  • The code changed/added as part of this pull request has been covered with tests, or this PR does not alter production code.
  • All tests related to the changed code pass in development, or tests are not applicable.

Code Review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
  • At least two engineers have been added as "Reviewers" on the pull request.
  • Changes have been reviewed by at least two other engineers who did not write the code.
  • This branch has been rebased off master to be current.

Tracking

  • Issue from Shortcut/Jira has a link to this pull request.
  • This PR has a link to the issue in Shortcut.

QA

  • This branch has been deployed to staging and tested.

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (16e35ce) 100.00% compared to head (14b8134) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master        #5   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           42        46    +4     
=========================================
+ Hits            42        46    +4     
Files Coverage Δ
lib/json.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josevsalina josevsalina requested a review from cgrayson January 15, 2025 20:57
@josevsalina josevsalina changed the title Update test.yml upgrade to node 20 Jan 15, 2025
@josevsalina josevsalina merged commit 20cb619 into master Jan 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants