Do not change the order of services in groups#32
Open
ivansopin wants to merge 1 commit intoadamcath:masterfrom
ivansopin:not-changing-service-order
Open
Do not change the order of services in groups#32ivansopin wants to merge 1 commit intoadamcath:masterfrom ivansopin:not-changing-service-order
ivansopin wants to merge 1 commit intoadamcath:masterfrom
ivansopin:not-changing-service-order
Conversation
Owner
|
@ivansopin I don't agree with this change. Services are not supposed to have launch-time dependencies. I'm almost inclined to go the opposite direction and randomize the order in which services are started, just to prevent accidental dependencies from forming. If we did want them to have dependencies, we should add a proper concept of dependencies, not squeeze it in as an invisible feature of groups. What's the use-case here? Maybe we can come up with a better solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@adamcath My change does not introduce the concept of dependencies either. It does honor the order, though, which follows the principle of least surprise. If you believe there is value in randomizing the order in which services run, there can be a flag for it, but that should certainly not be the default.