Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion BUILDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@ tools/test.py parallel/test-stream-* # The test/ prefix can be omitted
tools/test.py "test/parallel/test-stream-*"
```

The whildcard `*` can be used in any part of the path. For example, to run all tests
The wildcard `*` can be used in any part of the path. For example, to run all tests
with a name that starts with `test-inspector-`, regardless of the directory they are in:

```bash
Expand Down
30 changes: 15 additions & 15 deletions test/embedding/embedtest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -210,23 +210,23 @@ int RunNodeInstance(MultiIsolatePlatform* platform,
return 1;

exit_code = node::SpinEventLoop(env).FromMaybe(1);
}

if (!snapshot_blob_path.empty() && is_building_snapshot) {
snapshot = setup->CreateSnapshot();
assert(snapshot);

FILE* fp = fopen(snapshot_blob_path.c_str(), "wb");
assert(fp != nullptr);
if (snapshot_as_file) {
snapshot->ToFile(fp);
} else {
const std::vector<char> vec = snapshot->ToBlob();
size_t written = fwrite(vec.data(), vec.size(), 1, fp);
assert(written == 1);
if (!snapshot_blob_path.empty() && is_building_snapshot) {
snapshot = setup->CreateSnapshot();
assert(snapshot);

FILE* fp = fopen(snapshot_blob_path.c_str(), "wb");
assert(fp != nullptr);
if (snapshot_as_file) {
snapshot->ToFile(fp);
} else {
const std::vector<char> vec = snapshot->ToBlob();
size_t written = fwrite(vec.data(), vec.size(), 1, fp);
assert(written == 1);
}
int ret = fclose(fp);
assert(ret == 0);
}
int ret = fclose(fp);
assert(ret == 0);
}

node::Stop(env);
Expand Down
Loading