Skip to content

[PEDSP-20741] self-hosted runner added#16

Merged
sumitsamsung merged 1 commit intomasterfrom
chore/PEDSP-20741-self-hosted-runner-added
Jun 12, 2025
Merged

[PEDSP-20741] self-hosted runner added#16
sumitsamsung merged 1 commit intomasterfrom
chore/PEDSP-20741-self-hosted-runner-added

Conversation

@sumitsamsung
Copy link

self-hosted runner added

@sumitsamsung sumitsamsung requested a review from a team as a code owner June 10, 2025 09:30
Copy link

@pstefanskisamsung pstefanskisamsung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question - wouldn't that require an action from SRE to actually allow self-hosted runners to be triggered on this repo?

Copy link

@anuj-samsung anuj-samsung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, just make sure that rubocop runs properly on small type of runner, otherwise you can use medium one.

@sumitsamsung
Copy link
Author

Approving, just make sure that rubocop runs properly on small type of runner, otherwise you can use medium one.

does it usually have issues on small runners ?

@sumitsamsung
Copy link
Author

Question - wouldn't that require an action from SRE to actually allow self-hosted runners to be triggered on this repo?

thanks @pstefanskisamsung , yes, I have contacted SRE for the same

@anuj-samsung
Copy link

Approving, just make sure that rubocop runs properly on small type of runner, otherwise you can use medium one.

does it usually have issues on small runners ?

I have seen some issues in the past, I don't remember exactly though.

@sumitsamsung sumitsamsung merged commit 33e3ceb into master Jun 12, 2025
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants