Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/main/java/org/prebid/server/bidder/unruly/UnrulyBidder.java
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,10 @@
import org.prebid.server.bidder.model.BidderError;
import org.prebid.server.bidder.model.HttpRequest;
import org.prebid.server.bidder.model.Result;
import org.prebid.server.bidder.unruly.proto.UnrulyExtPrebid;
import org.prebid.server.exception.PreBidException;
import org.prebid.server.json.DecodeException;
import org.prebid.server.json.JacksonMapper;
import org.prebid.server.proto.openrtb.ext.ExtPrebid;
import org.prebid.server.proto.openrtb.ext.request.unruly.ExtImpUnruly;
import org.prebid.server.proto.openrtb.ext.response.BidType;
import org.prebid.server.proto.openrtb.ext.response.ExtBidPrebid;
import org.prebid.server.proto.openrtb.ext.response.ExtBidPrebidVideo;
Expand All @@ -34,7 +33,7 @@

public class UnrulyBidder implements Bidder<BidRequest> {

private static final TypeReference<ExtPrebid<?, ExtImpUnruly>> UNRULY_EXT_TYPE_REFERENCE =
private static final TypeReference<UnrulyExtPrebid> UNRULY_EXT_TYPE_REFERENCE =
new TypeReference<>() {
};

Expand All @@ -58,14 +57,17 @@ public Result<List<HttpRequest<BidRequest>>> makeHttpRequests(BidRequest request

private Imp modifyImp(Imp imp) {

final UnrulyExtPrebid unrulyExtPrebid = parseImpExt(imp);
return imp.toBuilder()
.ext(mapper.mapper().valueToTree(ExtPrebid.of(null, parseImpExt(imp))))
.ext(mapper.mapper().valueToTree(UnrulyExtPrebid.of(
unrulyExtPrebid.getBidder(),
unrulyExtPrebid.getGpid())))
.build();
}

private ExtImpUnruly parseImpExt(Imp imp) {
private UnrulyExtPrebid parseImpExt(Imp imp) {
try {
return mapper.mapper().convertValue(imp.getExt(), UNRULY_EXT_TYPE_REFERENCE).getBidder();
return mapper.mapper().convertValue(imp.getExt(), UNRULY_EXT_TYPE_REFERENCE);
} catch (IllegalArgumentException e) {
throw new PreBidException(e.getMessage());
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package org.prebid.server.bidder.unruly.proto;

import lombok.Value;
import org.prebid.server.proto.openrtb.ext.request.unruly.ExtImpUnruly;

@Value(staticConstructor = "of")
public class UnrulyExtPrebid {

ExtImpUnruly bidder;

String gpid;
}
18 changes: 18 additions & 0 deletions src/main/resources/bidder-config/teqblaze.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,24 @@ adapters:
url: https://usync.rocketlab.ai/pbserver?gdpr={{gdpr}}&consent={{gdpr_consent}}&us_privacy={{us_privacy}}&gpp={{gpp}}&gpp_sid={{gpp_sid}}&redirect={{redirect_url}}
support-cors: false
uid-macro: '[UID]'
appStockSSP:
enabled: false
# We have the following regional endpoint domains: 'lb' - for US_EAST, 'ortb-eu' - for EU, 'ortb-apac' - for APAC
# Please deploy this config in each of your datacenters with the appropriate regional subdomain
endpoint: https://#{REGION}#.al-ad.com/pserver
meta-info:
maintainer-email: sdksupport@app-stock.com
usersync:
enabled: true
cookie-family-name: appStockSSP
redirect:
url: https://csync.al-ad.com/pbserver?gdpr={{gdpr}}&gdpr_consent={{gdpr_consent}}&ccpa={{us_privacy}}&gpp={{gpp}}&gpp_sid={{gpp_sid}}&redir={{redirect_url}}
support-cors: false
uid-macro: '[UID]'
iframe:
url: "https://csync.al-ad.com/pbserverIframe?gdpr={{gdpr}}&gdpr_consent={{gdpr_consent}}&ccpa={{us_privacy}}&gpp={{gpp}}&gpp_sid={{gpp_sid}}&pbserverUrl={{redirect_url}}"
support-cors: false
uid-macro: '[UID]'
meta-info:
maintainer-email: github@teqblaze.com
app-media-types:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package org.prebid.server.bidder.unruly;

import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.node.IntNode;
import com.fasterxml.jackson.databind.node.ObjectNode;
import com.fasterxml.jackson.databind.node.TextNode;
Expand All @@ -19,7 +20,8 @@
import org.prebid.server.bidder.model.HttpRequest;
import org.prebid.server.bidder.model.HttpResponse;
import org.prebid.server.bidder.model.Result;
import org.prebid.server.proto.openrtb.ext.ExtPrebid;
import org.prebid.server.bidder.unruly.proto.UnrulyExtPrebid;
import org.prebid.server.proto.openrtb.ext.request.unruly.ExtImpUnruly;

import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -65,6 +67,27 @@ public void makeHttpRequestsShouldReturnOneRequestPerImpWithExpectedHeaders() {
tuple("Accept", "application/json"));
}

@Test
public void makeHttpRequestsShouldPassThroughGPID() {
// given
final BidRequest bidRequest = BidRequest.builder()
.imp(singletonList(givenImp(identity())))
.build();

// when
final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);

// then
assertThat(result.getValue()).hasSize(1)
.extracting(HttpRequest::getPayload)
.flatExtracting(BidRequest::getImp)
.extracting(Imp::getExt)
.extracting(ext -> ext.get("gpid"))
.extracting(JsonNode::asText)
.first()
.isEqualTo("gpid");
}

@Test
public void makeBidsShouldReturnErrorIfResponseBodyCouldNotBeParsed() {
// given
Expand Down Expand Up @@ -288,7 +311,7 @@ private static BidRequest givenBidRequest(Function<Imp.ImpBuilder, Imp.ImpBuilde

private static Imp givenImp(Function<Imp.ImpBuilder, Imp.ImpBuilder> impCustomizer) {
final ObjectNode impExt = mapper.valueToTree(
ExtPrebid.of(null, mapper.createObjectNode().set("siteId", IntNode.valueOf(123))));
UnrulyExtPrebid.of(ExtImpUnruly.of(123), "gpid"));

return impCustomizer.apply(
Imp.builder()
Expand Down
37 changes: 37 additions & 0 deletions src/test/java/org/prebid/server/it/AppStockSspTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
package org.prebid.server.it;

import io.restassured.response.Response;
import org.json.JSONException;
import org.junit.jupiter.api.Test;
import org.prebid.server.model.Endpoint;

import java.io.IOException;

import static com.github.tomakehurst.wiremock.client.WireMock.aResponse;
import static com.github.tomakehurst.wiremock.client.WireMock.equalToJson;
import static com.github.tomakehurst.wiremock.client.WireMock.post;
import static com.github.tomakehurst.wiremock.client.WireMock.urlPathEqualTo;
import static java.util.Collections.singletonList;

public class AppStockSspTest extends IntegrationTest {

@Test
public void openrtb2AuctionShouldRespondWithBidsFromAppStockSsp() throws IOException, JSONException {
// given
WIRE_MOCK_RULE.stubFor(post(urlPathEqualTo("/appstockssp-exchange"))
.withRequestBody(equalToJson(
jsonFrom("openrtb2/appstockssp/test-appstockssp-bid-request.json")))
.willReturn(aResponse().withBody(
jsonFrom("openrtb2/appstockssp/test-appstockssp-bid-response.json"))));

// when
final Response response = responseFor("openrtb2/appstockssp/test-auction-appstockssp-request.json",
Endpoint.openrtb2_auction);

// then
assertJsonEquals(
"openrtb2/appstockssp/test-auction-appstockssp-response.json",
response,
singletonList("appStockSSP"));
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
{
"id": "request_id",
"imp": [
{
"id": "imp_id",
"banner": {
"w": 300,
"h": 250
},
"secure": 1,
"ext": {
"bidder": {
"type": "publisher",
"placementId": "testPlacementId"
}
}
}
],
"site": {
"domain": "www.example.com",
"page": "http://www.example.com",
"publisher": {
"domain": "example.com"
},
"ext": {
"amp": 0
}
},
"device": {
"ua": "userAgent",
"ip": "193.168.244.1"
},
"at": 1,
"tmax": "${json-unit.any-number}",
"cur": [
"USD"
],
"source": {
"tid": "${json-unit.any-string}"
},
"regs": {
"ext": {
"gdpr": 0
}
},
"ext": {
"prebid": {
"server": {
"externalurl": "http://localhost:8080",
"gvlid": 1,
"datacenter": "local",
"endpoint": "/openrtb2/auction"
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"id": "request_id",
"seatbid": [
{
"bid": [
{
"id": "bid_id",
"impid": "imp_id",
"price": 3.33,
"crid": "creativeId",
"mtype": 1,
"ext": {
"prebid": {
"type": "banner"
}
}
}
]
}
]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"id": "request_id",
"imp": [
{
"id": "imp_id",
"banner": {
"w": 300,
"h": 250
},
"ext": {
"appStockSSP": {
"placementId": "testPlacementId"
}
}
}
],
"tmax": 5000,
"regs": {
"ext": {
"gdpr": 0
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
{
"id": "request_id",
"seatbid": [
{
"bid": [
{
"id": "bid_id",
"impid": "imp_id",
"exp": 300,
"price": 3.33,
"crid": "creativeId",
"mtype": 1,
"ext": {
"origbidcpm": 3.33,
"prebid": {
"type": "banner",
"meta": {
"adaptercode": "appStockSSP"
}
}
}
}
],
"seat": "appStockSSP",
"group": 0
}
],
"cur": "USD",
"ext": {
"responsetimemillis": {
"appStockSSP": "{{ appStockSSP.response_time_ms }}"
},
"prebid": {
"auctiontimestamp": 0
},
"tmaxrequest": 5000
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -575,6 +575,8 @@ adapters.teqblaze.aliases.pinkLion.enabled=true
adapters.teqblaze.aliases.pinkLion.endpoint=http://localhost:8090/pinkLion-exchange
adapters.teqblaze.aliases.rocketlab.enabled=true
adapters.teqblaze.aliases.rocketlab.endpoint=http://localhost:8090/rocketlab-exchange
adapters.teqblaze.aliases.appStockSSP.enabled=true
adapters.teqblaze.aliases.appStockSSP.endpoint=http://localhost:8090/appstockssp-exchange
adapters.theadx.enabled=true
adapters.theadx.endpoint=http://localhost:8090/theadx-exchange
adapters.tradplus.enabled=true
Expand Down
Loading