Skip to content

ci: only allowed sonar job to read PRs and added --ignore-scripts parameter #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rH4rtinger merged 2 commits into from
Jan 5, 2026
Merged

ci: only allowed sonar job to read PRs and added --ignore-scripts parameter #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
add5d4e
ci: only allowed sonar job to read PRs
rH4rtinger Jan 2, 2026
4c69027
ci: adding --ignore-scripts to prevent script injections
rH4rtinger Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ on:
branches: ["main"]
pull_request:

permissions:
pull-requests: read # allows SonarCloud to decorate PRs with analysis results

jobs:
build:
strategy:
Expand All @@ -31,7 +28,7 @@ jobs:
node_modules-${{ matrix.os }}-node-${{ matrix.node-version }}

- name: Run clean install
run: npm ci
run: npm ci --ignore-scripts

- name: Run tests
run: npm test
Expand All @@ -40,6 +37,8 @@ jobs:
name: Run eslint and sonar scanning
runs-on: ubuntu-latest
needs: build
permissions:
pull-requests: read # allows SonarCloud to decorate PRs with analysis results
steps:
- name: Checkout code
uses: actions/checkout@v6
Expand All @@ -61,9 +60,9 @@ jobs:
run: npm run lint -- --format json --output-file eslint-results.json || true

- name: Install Coverage Reporters
run: npm install -g nyc
run: npm install --ignore-scripts -g nyc
- name: Install Mocha reporters
run: npm install -d mocha-multi-reporters mocha-junit-reporter mocha-sonarqube-reporter
run: npm install --ignore-scripts -d mocha-multi-reporters mocha-junit-reporter mocha-sonarqube-reporter
- name: create mocha config
run: |
echo '{
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/npm-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- name: Update npm
run: npm install -g npm@latest
- run: npm -v
- run: npm ci
- run: npm ci --ignore-scripts
- run: npm run compile
- run: npm test
- run: npm publish