feature(component-directive): make the component directive extensible#48
Open
niekraaijmakers wants to merge 4 commits intoadobe:masterfrom
Open
Conversation
10 tasks
added 2 commits
June 15, 2021 14:21
…component-directive-extensibility-2
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
=======================================
Coverage 87.71% 87.71%
=======================================
Files 10 10
Lines 171 171
Branches 29 29
=======================================
Hits 150 150
Misses 14 14
Partials 7 7
Continue to review full report at Codecov.
|
|
hi, there's news? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding some hooks that can be used to extend the component directive class.
This will enable the content fragment component to reuse this logic instead of duplicating it.
Pending PR : #46
Related Issue
#43
How Has This Been Tested?
Unit tested
Screenshots (if appropriate):
Types of changes
Checklist: