Skip to content

fix: add kinds nodejs:18 and nodejs:20, update all image versions to 3.0.41#109

Open
shazron wants to merge 1 commit intoadobe:masterfrom
shazron:add-nodejs-18-kind
Open

fix: add kinds nodejs:18 and nodejs:20, update all image versions to 3.0.41#109
shazron wants to merge 1 commit intoadobe:masterfrom
shazron:add-nodejs-18-kind

Conversation

@shazron
Copy link
Member

@shazron shazron commented Feb 8, 2024

Description

Required by adobe/asset-compute-integration-tests#43
Needs a new plugin release as well, after.

nodejs:18 is the default kind, and nodejs:20 is also supported: run curl https://adobeioruntime.net to see all images supported and tags.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@tmathern tmathern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing... ?

@shazron
Copy link
Member Author

shazron commented Mar 5, 2024

@tmathern How can I get the tests to pass? I think the tests don't run because its on a fork.

@tmathern
Copy link
Member

tmathern commented Mar 13, 2024

@tmathern How can I get the tests to pass? I think the tests don't run because its on a fork.

Try to run them locally, post the test report and we'd be good! (Do you see the logs/failures? You should be able to...).

@shazron
Copy link
Member Author

shazron commented Mar 14, 2024

@tmathern I can't make the tests pass - they don't even pass on the master branch (which of course doesn't have my code). So it seems that it is something that needs to be fixed in master first? I tried to dig into it but I couldn't find where that failing code is exactly.

I tested on macOS, Linux, and even Windows (but the tests don't even run on Windows - the call to docker has "too many colons")

The common error is (34 failures):

Actions:
- worker

Running tests in test/asset-compute/worker


Error: Could not init action on container (POST http://0.0.0.0:32792/init: responded with error: Initialization has failed due to: /nodejsAction/aKxyo343/index.js:116417
                size.type = size.type ?? type;
                                       ^

SyntaxError: Unexpected token ?
    at Module._compile (internal/modules/cjs/loader.js:723:23)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at eval (eval at <anonymous> (/nodejsAction/runner.js:65:49), <anonymous>:1:1)
    at /nodejsAction/runner.js:65:49
    at process._tickCallback (internal/process/next_tick.js:68:7)

@anianweber
Copy link

Are there any news on this PR? Would be nice to get Node 18 and 20 to work. Additionally it might be nice to add Node 22 and 24 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants