Skip to content

Conversation

@purplecabbage
Copy link
Member

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the deprecated auditUserId functionality and adds defensive handling for undefined cache duration configuration values. The changes prevent potential issues when cache configuration properties are missing while simplifying the metadata handling logic.

  • Removed auditUserId metadata from S3 upload operations
  • Added null checks for cache duration configurations (htmlCacheDuration, jsCacheDuration, cssCacheDuration, imageCacheDuration)
  • Refactored _getCacheControlConfig method to use explicit null returns when cache durations are undefined

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
lib/remote-storage.js Removed auditUserId metadata handling and refactored cache control logic to return null when cache duration configs are undefined
test/lib/remote-storage.test.js Added tests for undefined cache duration scenarios and updated existing test to reflect removal of auditUserId metadata

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@purplecabbage purplecabbage merged commit c997b22 into master Dec 5, 2025
17 checks passed
@purplecabbage purplecabbage deleted the ACNA-4207 branch December 5, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants