Open
Conversation
dconnelly84
reviewed
Oct 7, 2025
| 'memory/memory.limit_in_bytes': 'memory.max', | ||
| 'cpuacct/cpuacct.usage': 'cpu.stat', | ||
| 'cpuacct/cpuacct.stat': 'cpu.stat' | ||
| }; |
There was a problem hiding this comment.
nit: since these are hardcoded, should we modify the readme on the procedure to add more metrics if needed in the future?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for reading metrics from cgroupv2 (the new Ethos default), with automatic fallback to cgroupv1.
Similar change was made at adobe/asset-compute-pipeline#98
Related Issue
Partial fix for https://jira.corp.adobe.com/browse/ASSETS-12635
Motivation and Context
Ethos containers are using cgroupv2 by default, which node-cgroup-metrics does not currently support.
How Has This Been Tested?
Tests have been added in metrics.test.js
Manual tests have been performed by using nui app deploy.
Types of changes
Checklist: