Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 68 67 -1
=========================================
- Hits 68 67 -1
Continue to review full report at Codecov.
|
Contributor
|
please fix the failing unit tests for node 10.16, 10.19 & 12.16 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
node-fetch v3 has been released. This PR serves for starting the discussion of updating node-fetch-retry to allow use of v3, which is ESM only. A full conversion of node-fetch-retry to ESM is not necessary when using async import.
Minimum node version required would be 12.20
https://github.com/node-fetch/node-fetch/blob/main/docs/v3-UPGRADE-GUIDE.md
Fixes # (issue)
Types of changes
Checklist: