Skip to content

Build command#92

Closed
jonsnyder wants to merge 2 commits intoadobe:masterfrom
jonsnyder:buildCommand
Closed

Build command#92
jonsnyder wants to merge 2 commits intoadobe:masterfrom
jonsnyder:buildCommand

Conversation

@jonsnyder
Copy link

Description

Currently, the only way to build a test library is to run the sandbox and then get /launch...js. This adds a command to the CLI and lib version to build the test library. Additionally, you can pass a container object to the library build method. This greatly simplifies Web SDKs runtime tests. See https://github.com/adobe/reactor-extension-alloy/pull/295/files

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jonsnyder
Copy link
Author

Closed in favor of #93

@jonsnyder jonsnyder closed this Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant