Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This PR will trigger no release when merged. |
vivesing
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made
Adds brand-level LLMO config endpoints that bridge v2 customer configs with per-site v1 LLMO configs, enabling reading and writing v1 configs scoped to a brand.
GET /v2/orgs/:spaceCatId/brands/:brandId/llmo/configendpoint that resolves brand URLs to SpaceCat sites and fetches each site's v1 LLMO config from S3PATCH /v2/orgs/:spaceCatId/brands/:brandId/llmo/configendpoint that validates site ownership against the brand, then delegates per-site config writes to the existing v1updateLlmoConfigpipelinestripMetadataincustomer-config-v2-metadata.jsto also strip enrichment/computed fields (brandId,brandName,category,topic,totalCategories,totalTopics,totalPrompts) so PATCH diff comparisons ignore GET-only fieldscustomer-config-api.yamlorganization:read/organization:write)stripMetadatahelperRelated Issues
Relates to
Testing the PR changes
npm start.GET /v2/orgs/{spaceCatId}/brands/{brandId}/llmo/configwith valid IMS/API key credentials — verify it returns an array of{ siteId, baseURL, config }objects.PATCH /v2/orgs/{spaceCatId}/brands/{brandId}/llmo/configwith a body like[{ "siteId": "<id>", "config": { ... } }]— verify per-site results withstatus: "success"and aversionfield.status: "error"in the results array).403for non-LLMO-administrator users.npm test— confirm all new tests intest/controllers/brands.test.jsandtest/support/customer-config-v2-metadata.test.jspass.Screenshots/Videos
No screenshots available.
Additional Notes
N/A