Skip to content

[MWPW-158444] Added stage domains map#411

Merged
aishwaryamathuria merged 13 commits intostagefrom
mwpw-158444-domains-map
Sep 19, 2024
Merged

[MWPW-158444] Added stage domains map#411
aishwaryamathuria merged 13 commits intostagefrom
mwpw-158444-domains-map

Conversation

@aishwaryamathuria
Copy link
Collaborator

@aishwaryamathuria aishwaryamathuria commented Sep 18, 2024

< @robert-bogos opening this PR from robert-bogos#1 >
This PR adds the stageDomainsMap, enabling the conversion of production URLs to their stage equivalents in the stage environment.
More details about this feature can be found in this discussion.

Resolves: MWPW-158444

Test URLs:

Before: https://main--cc--adobecom.hlx.live/careers?martech=off
After: https://mwpw-158444-domains-map--cc--adobecom.hlx.live/careers?martech=off

@aishwaryamathuria aishwaryamathuria requested a review from a team September 18, 2024 09:09
@aem-code-sync
Copy link

aem-code-sync bot commented Sep 18, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 18, 2024

Page Scores Audits Google
📱 /careers?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /careers?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to mwpw-158444-domains-map September 18, 2024 09:13 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to mwpw-158444-domains-map September 18, 2024 09:14 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to mwpw-158444-domains-map September 18, 2024 09:18 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to mwpw-158444-domains-map September 18, 2024 09:22 Inactive
@milo-pr-merge-cc
Copy link

Skipped merging 411: [MWPW-158444] Added stage domains map due to missing verified label. kindly make sure that the PR has been verified

@spadmasa spadmasa self-assigned this Sep 18, 2024
@spadmasa
Copy link
Collaborator

Hi @robert-bogos
Before the milo pr merge in stage we had firefly, news , business , blog , helpx links all pointing to stage in https://www.stage.adobe.com/products/firefly.html
now after the pr merge we see all links are pointing to prod in stage and with the current pr we are seeing only the www.stage.adobe.com is getting replaced with branch
{C0589461-50D8-4DFA-A014-A5E5ED6D813A}

can you please confirm on this if the other domain urls will not be included as part of this pr.

CC : @aishwaryamathuria , @salonijain3 , @sigadamvenkata , @Ruchika4

@aem-code-sync aem-code-sync bot temporarily deployed to mwpw-158444-domains-map September 18, 2024 16:14 Inactive
@robert-bogos
Copy link
Collaborator

Hi @spadmasa ! I've updated the current stageDomainsMap to preserve the behaviour you're talking about

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@aem-code-sync aem-code-sync bot temporarily deployed to mwpw-158444-domains-map September 18, 2024 16:16 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to mwpw-158444-domains-map September 19, 2024 04:01 Inactive
@milo-pr-merge-cc
Copy link

Skipped merging 411: [MWPW-158444] Added stage domains map due to failing checks

@aem-code-sync aem-code-sync bot temporarily deployed to mwpw-158444-domains-map September 19, 2024 05:13 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.37%. Comparing base (4e8b5df) to head (ee827b5).
Report is 79 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #411      +/-   ##
==========================================
- Coverage   90.26%   86.37%   -3.89%     
==========================================
  Files          17       19       +2     
  Lines        2301     2591     +290     
==========================================
+ Hits         2077     2238     +161     
- Misses        224      353     +129     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aem-code-sync aem-code-sync bot temporarily deployed to mwpw-158444-domains-map September 19, 2024 05:15 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to mwpw-158444-domains-map September 19, 2024 05:15 Inactive
Copy link
Collaborator

@robert-bogos robert-bogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@spadmasa
Copy link
Collaborator

@aem-code-sync aem-code-sync bot temporarily deployed to mwpw-158444-domains-map September 19, 2024 08:12 Inactive
@spadmasa
Copy link
Collaborator

Validation done in business.adobe.com as well see the stage domain links coming now
https://mwpw-158444-domains-map--cc--adobecom.hlx.page/products/firefly
{5292AD52-9FA2-4681-B85A-E7BF9121FE6F}
{C5B3249C-7196-44EF-BDBF-7EAF417E2EB1}

@aishwaryamathuria aishwaryamathuria merged commit cd3eeab into stage Sep 19, 2024
@spadmasa spadmasa added the ready for main PR is ready to be merged to main branch label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for main PR is ready to be merged to main branch ready for stage verified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants