Skip to content

[MWPW-189040][DoodleBug] - Visibility of next carousel is seen more when compared to Figma #891

Merged
nkthakur48 merged 11 commits intostagefrom
doodlebug-fix
Mar 9, 2026
Merged

[MWPW-189040][DoodleBug] - Visibility of next carousel is seen more when compared to Figma #891
nkthakur48 merged 11 commits intostagefrom
doodlebug-fix

Conversation

@drashti1712
Copy link
Collaborator

@drashti1712 drashti1712 commented Mar 3, 2026

@aem-code-sync
Copy link

aem-code-sync bot commented Mar 3, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync
Copy link

aem-code-sync bot commented Mar 3, 2026

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@milo-pr-merge-cc
Copy link

Skipped merging 891: [MWPW-189040][DoodleBug] - Visibility of next carousel is seen more when compared to Figma due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 891: [MWPW-189040][DoodleBug] - Visibility of next carousel is seen more when compared to Figma due to missing verified label. kindly make sure that the PR has been verified

@drashti1712 drashti1712 requested a review from nkthakur48 March 4, 2026 19:52
@nkthakur48
Copy link
Collaborator

@suhjainadobe Could you please review the PR?

@drashti1712 drashti1712 requested a review from suhjainadobe March 5, 2026 08:04
@milo-pr-merge-cc
Copy link

Skipped merging 891: [MWPW-189040][DoodleBug] - Visibility of next carousel is seen more when compared to Figma due to missing verified label. kindly make sure that the PR has been verified

@SushmaNayak630
Copy link

Hi @drashti1712 , the given fix is working only in Samsung Galaxy S8+
image
issue still there in iphone and samsung s20
image
image
Could you please confirm on this

@nkthakur48
Copy link
Collaborator

@drashti1712 Could you please look at @SushmaNayak630's comment
CC: @suhjainadobe

@drashti1712
Copy link
Collaborator Author

Hi @SushmaNayak630
This is expected because as the screen width increases, the next slide would be more visible. According to figma, the carousel slide width is 300px and the gap is 16px between the slides. For devices with 360px screen width, the next slide would be seen only a little (according to figma). But for devices with screen width greater than 360px, the next slide would be seen more as the carousel width 300px and the gap 16 px remains fixed. This was also discussed with @spadmasa.

cc: @nkthakur48 @suhjainadobe

@spadmasa
Copy link
Collaborator

spadmasa commented Mar 6, 2026

Validation on the pr in s8 as advised
#891
https://doodlebug-fix--cc--adobecom.aem.live/drafts/doodlebug/remove-object
image
image

@milo-pr-merge-cc
Copy link

Error merging 891: [MWPW-189040][DoodleBug] - Visibility of next carousel is seen more when compared to Figma Required status check "aem-psi-check" is expected.

@drashti1712
Copy link
Collaborator Author

Initially jira mentioned 'ipad' as well for the fix. However, after discussion with the team, it was confirmed to only apply changes for mobile. I had updated the breakpoint accordingly.

@nkthakur48 nkthakur48 merged commit dea6a40 into stage Mar 9, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants