Conversation
…uld not be nested
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
Contributor
|
This looks good @vipu0303 for foreground image. Thanks for getting this done. |
Ruchika4
approved these changes
Mar 6, 2026
sanjayms01
approved these changes
Mar 6, 2026
nkthakur48
reviewed
Mar 6, 2026
| } else eagerLoad(firstBlock.querySelector(':scope div:last-child > div img')); | ||
| break; | ||
| } | ||
| case firstBlock?.classList.contains('upload-marquee'): { |
Collaborator
There was a problem hiding this comment.
As discussed, could you please check if something like
and could be explored?
nkthakur48
reviewed
Mar 6, 2026
Collaborator
nkthakur48
left a comment
nkthakur48
left a comment
There was a problem hiding this comment.
Please ensure to check your changes in a slow n/w connection. There shouldn’t be any flicker
|
Looks fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eager loading of the LCP image in upload marquee to improve performance.
Resolves: MWPW-189649
Test URLs: