Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stage #772 +/- ##
==========================================
- Coverage 70.38% 70.21% -0.18%
==========================================
Files 108 107 -1
Lines 24785 24743 -42
==========================================
- Hits 17446 17373 -73
- Misses 7339 7370 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The test link 404s for me |
|
I updated the test link. It now loads. |
| const { tokenInfo } = window.adobeIMS ? await window.adobeIMS.refreshToken() : {}; | ||
| return tokenInfo; | ||
| } catch (e) { | ||
| return { |
There was a problem hiding this comment.
Is this logged somewhere?
There was a problem hiding this comment.
We don't log in getRefreshToken because errors are already logged at the API boundaries where operations fail for fetchRatingsData and submitRating. This avoids redundant logging. If we were to log here we would generate multiple LANA entries for the same underlying issue. The error is properly captured and returned to the caller for handling. We don't show the ratings block if the token is unavailable so the user experience is protected if for some reason they don't receive an IMS accessToken.
Summary
Briefly describe the features or fixes introduced in this PR.
Jira Ticket
Resolves: MWPW-182092
Test URLs
Verification Steps
Potential Regressions
Additional Notes
(If applicable) Add context, related PRs, or known issues here.