Setting up setCookie and getCookie modules#3
Open
vickymeenakshisundaram wants to merge 1 commit intoadobecom:mainfrom
Open
Setting up setCookie and getCookie modules#3vickymeenakshisundaram wants to merge 1 commit intoadobecom:mainfrom
vickymeenakshisundaram wants to merge 1 commit intoadobecom:mainfrom
Conversation
sharmrj
reviewed
Jun 30, 2025
| if (httpOnly) cookieString += `; HttpOnly`; | ||
| if (sameSite) cookieString += `; SameSite=${sameSite}`; | ||
|
|
||
| const key = Object.keys(headers).find(k => k.toLowerCase() === 'set-cookie') || 'set-cookie'; |
Collaborator
There was a problem hiding this comment.
Is it necessary to to iterate all the headers every time? Why not do
const existing = headers['Set-Cookie'] ?? headers['set-cookie'];
sharmrj
reviewed
Jun 30, 2025
| } | ||
|
|
||
| export const getCookie = (headers: Headers) => (name: string): Cookie | undefined => { | ||
| const cookieKey = Object.keys(headers).find(k => k.toLowerCase() === 'cookie'); |
Collaborator
There was a problem hiding this comment.
Again, instead of iterating through the headers, couldn't we do const cookies = headers['Cookie'] ?? headers ['cookie'];
sharmrj
reviewed
Jun 30, 2025
Comment on lines
+73
to
+75
| const cookieString = headers[cookieKey].join('; '); | ||
| const cookieParts = cookieString.split(';').map(c => c.trim()); | ||
|
|
Collaborator
There was a problem hiding this comment.
Why join only to immediately split again?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setup setCookie and getCookie modules
Resolves MWPW-175571