@releng first draft of code structure guideline#604
@releng first draft of code structure guideline#604npeltier wants to merge 6 commits intoadobecom:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #604 +/- ##
==========================================
- Coverage 84.14% 84.14% -0.01%
==========================================
Files 180 180
Lines 49064 49064
==========================================
- Hits 41284 41283 -1
- Misses 7780 7781 +1 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| | common | Holds main views, top bar, etc... | | ||
| | common/constants | Holds constants reused across code | | ||
| | common/fields | Holds fields reused across different UIs (e.g., mas-locale-picker) | | ||
| | common/repository | Repository interaction features | |
There was a problem hiding this comment.
we could keep aem.js somewhere, and break mas-repository.js fully down and move pieces in appropriate folders like fragments, placeholders, promotions.
Not sure at the end we will have repository interaction features appart.
There was a problem hiding this comment.
i agree, i think we can keep core generic features in common/repository, and the one that are specific in dedicated feature folders, with naming model, or together with the dedicated store?
| | ----------------- | ------------------------------------------------------------------ | | ||
| | common | Holds main views, top bar, etc... | | ||
| | common/constants | Holds constants reused across code | | ||
| | common/fields | Holds fields reused across different UIs (e.g., mas-locale-picker) | |
There was a problem hiding this comment.
I somehow don't like the common parent.
There was a problem hiding this comment.
well, it's the price for having direct feature wise sibling
| | common/repository | Repository interaction features | | ||
| | common/store | Model common utitilies | | ||
| | common/utils | Holds common utils | | ||
| | fragments | Views, models, specific to fragments view | |
There was a problem hiding this comment.
so card and collection editor go here in fragments? because everything is a fragment at the end.
There was a problem hiding this comment.
then how come placeholders are separate? they are also fragments :D
There was a problem hiding this comment.
:) yes, and collections are too and will have their own UI, it's UI here, not data type
There was a problem hiding this comment.
what ui is fragment? /content one?
3 participants
No description provided.